Post by Phyren
Hands down the best tanking professions are JC and BS. JC, because you can equip 3
Solid Dragon's Eyes. And BS because you can have 2 extra slots.
If you really need help deciding, there is a sticky at the top of the forum that has more helpful threads that could help you in your decision.
Not necessarily. Jewelcrafting yes, fantastic end-game profession for any class that has a gem slot color that's essentially gimping themselves by missing out on a socket bonus or taking a non-preferred gem (hunters and blue sockets). Blacksmithing, however, while it is definitely great for a plate wearer leveling up if you keep it consistent with your actual level, isn't a lock in for best. Assuming you use your two extra sockets with Solid Sky Sapphires (+24 Stam), which is what virtually all tanks will use it for, you get the exact same bonus from a profession like Enchanting, with the +24 Stam enchants on rings.
If you're concerned about getting professions that will give you an extra little push in the end-game, Jewelcrafting definitely. For too many reasons this profession is great, albeit expensive to level. If you keep the gear you can make consistent with your level, Blacksmithing might be what you want, but ultimately you can leave your second profession to personal preference, and the profession that appears most profitable on your server (besides engineering, which wouldn't be anyway), is probably going to be your best bet.