This site makes extensive use of JavaScript.
Please
enable JavaScript
in your browser.
Live
PTR
Classic
TBC
A bit of information regarding Spirit Shell and Addons.
Post Reply
Return to board index
Post by
laalipop
So this game to my attention this evening and I'd just like to inform people of what I figured out.
I heal using Grid and I have GridStatusShields to track absorbs on the group, after it updated, I was a little concerned because I noticed Spirit Shell's numbers were not showing up, I also noticed that Spirit Shell's numbers were not showing up on Recount as well. I did some digging.
The only way that I know of to pull back data for Absorbs is through the tooltips, parsing the string to get the data you need. So I looked there to find that Spirit Shell's tooltip reads "Absorbing X Damage" where PW:S, DA and most other absorbs read "Absorbs X Damage" I don't know if anyone is looking to use Spirit Shell into their addons functionality anywhere, but I just wanted to pass on the information that the difference in the tooltip seems to be making Spirit Shell invisible to track.
Post by
Neffi
It's times like this when a library needs to be developed.
Not when you need to
format money
. (Just kidding, but libs are seriously overused sometimes.)
Since you're already using code to accomplish this, why split it into a library for the benefit of us all? When this happens again, anyone using it can push a patch through, and then any addon using it just needs to pull the new lib in to be totally up-to-date with new data.
Wait a second, is there not already a lib to do this?
Post by
laalipop
I'm very new to sifting through addon code. This addon happened to be easy, just needing to add a condition to look for a new string where he sifted through the tooltips, I'd need to do a lot more digging if I wanted to help with Recount and bigger addons like that.
Post by
Neffi
I was under the assumption it was your addon. Don't worry about it then. If these authors find it in their hearts to delegate their hard work into a library, all the better for the community. If not, whatever. If I ever needed to do something like this, I'm sure I'd take the library approach anyway (if it doesn't already exist).
Post Reply
You are not logged in. Please
log in
to post a reply or
register
if you don't already have an account.
© 2021 Fanbyte
