This site makes extensive use of JavaScript.
Please enable JavaScript in your browser.
Live
PTR
10.2.7
PTR
10.2.6
Beta
Add Wowhead tooltips to your forums or CMS.
Return to board index
Post by
Lockslap
Itemsets has issues with the Valorous gear sets. I am wondering if this has to do with them having an itemset number of, for example, -31 for Valorous Bonescythe Battlegear ? Either way, only the Hero gear works.
I am also getting double entries for every single item in the set (2 chests listed, 2 gloves, etc)
Also, perhaps a toggle on the craftables bbcode to enable / disable the listing of mats. In most cases, the name followed by the spell is sufficient, especially when you are using it in a block of text.
You are exactly right, the script only looks for positive (>0) numbers. I will adjust it to look for negative numbers as well.
I will also add a nomats modifier to the craft tags so that it won't display any of the mats.
Thanks for the suggestions.
Post by
Lockslap
Version 3.0.1 BETA Released
No real major changes, just the fixes that Caldar posted about above. To update replace the files listed below with the files from the zip file linked above.
parse.php
wowhead_cache.php
wowhead_craftable.php
wowhead_itemset.php
Let me know how it works.
Later guys,
craCkpot
Post by
Caldar
Upgraded to 3.0.1
Script now properly shows the Valorous sets.
After the page has been refreshed a few times, the Heroe's sets all start showing every item twice like it was before. This happens (at least) for all the sets entered as Heroes' or just the set name without the Heroe's or Valorous prefix. This doesn't happen to the Valorous sets.
What is the correct syntax for the nomats craftables? Ive tried and it outputs a blank line.
Post by
Caldar
Wondering if the double listing isn't because both (for example) Heroes' Scourgeborne Battlegear and Scourgeborne Battlegear return the same items that it is double listing them and that is why this isn't happening to the Valorous sets.
Post by
Lockslap
Wondering if the double listing isn't because both (for example) Heroes' Scourgeborne Battlegear and Scourgeborne Battlegear return the same items that it is double listing them and that is why this isn't happening to the Valorous sets.
That is most likely what is going on, I'm going to look into see what's going on and try to find a work around.
Post by
Caldar
What is the correct syntax for the nomats argument?
produces a blank line.
NM, figured this out. is correct. Your upgrade 3.0.0 -> 3.0.1 didn't mention the new pattern files and I had only updated the files listed.
Post by
Caldar
Wondering if the double listing isn't because both (for example) Heroes' Scourgeborne Battlegear and Scourgeborne Battlegear return the same items that it is double listing them and that is why this isn't happening to the Valorous sets.
That is most likely what is going on, I'm going to look into see what's going on and try to find a work around.
There is no issue as long as someone doesn't list a 7/7.5 itemset without a prefix. If they do it makes a new entry for that set in the itemset table and it also relists all the items a second time in the itemset_reagent table even though all of those items are already there. This makes the double entries. I would assume perhaps some sort of check to make sure an itemset number isn't already in the itemset_reagent table would fix this? The entries in the itemset table don't hurt anything because they just pull the same items from the itemset_reagent table anyway.
Post by
293107
This post was from a user who has deleted their account.
Post by
315298
This post was from a user who has deleted their account.
Post by
Lockslap
Wondering if the double listing isn't because both (for example) Heroes' Scourgeborne Battlegear and Scourgeborne Battlegear return the same items that it is double listing them and that is why this isn't happening to the Valorous sets.
That is most likely what is going on, I'm going to look into see what's going on and try to find a work around.
There is no issue as long as someone doesn't list a 7/7.5 itemset without a prefix. If they do it makes a new entry for that set in the itemset table and it also relists all the items a second time in the itemset_reagent table even though all of those items are already there. This makes the double entries. I would assume perhaps some sort of check to make sure an itemset number isn't already in the itemset_reagent table would fix this? The entries in the itemset table don't hurt anything because they just pull the same items from the itemset_reagent table anyway.
That would be ideal, yes, but the only problem is that unless they supply an ID for the tag rather than the name, the script doesn't know the ID. The main problem is that the script doesn't currently support IDs for craftables and itemsets. Haven't gotten around to it yet. I script only knows the ID when it: A) gets it from Wowhead B) gets it from MySQL.
In my testing when using Scourgeborne Battlegear it displays the Heroes' set, which makes sense due to it being the first set listed on the search page when going
here
. However, when you do provide the Heroes' or Valorous prefixes it correctly gets and displays them, as well as saving them to the cache for later use.
Perhaps you could clarify what is going on, or even better show an example. That way I can better understand and fix it. Also changing define('WOWHEAD_DEBUG', false); to define('WOWHEAD_DEBUG', true); in config.php could point to the problem. This will turn on debugging mode which will messily display what it finds as it works it way through the code.
By the way, in a few minutes a pretty big update is coming (for the SMF users anyways =D).
Post by
Lockslap
Version 3.0.2 Released
and
SMF v1.x Supported Added!
Okay everyone, version 3.0.2 is now out and ready for you to tear into. I have decided to remove the BETA tag as it seems to have been tested pretty well, with both good and bad results, lol. You can find the changelog for it
here
.
Also included are the installation instructions for running this script on SMF version 1.x (I believe I'm using 1.1.7) and you can find those
here
. I will do my best to support SMF installations, but I have never used SMF before so I'm learning as I go. I must say though I really like the way it looks and works. It is also XHTML and CSS W3C compliant, so you can't go wrong there. Please be aware that this script will
always
be tested using phpBB3, but it shouldn't effect the way it runs on SMF.
WHEN UPDATING TO THIS VERSION YOU MUST RUN create_table.php AGAIN DUE TO THE RENAMING OF THE MYSQL TABLES.
You may delete the old tables that it was using in previous versions.
Enjoy guys n' gals!
craCkpot
Post by
315298
This post was from a user who has deleted their account.
Post by
22027
This post was from a user who has deleted their account.
Post by
Lockslap
Damn :(
Any possible support for Joomla 1.5?:(
It is coming sometime this week, I have to install Joomla on my webserver and set it up. Then I can work out how to get it running.
Post by
293107
This post was from a user who has deleted their account.
Post by
315298
This post was from a user who has deleted their account.
Post by
Lockslap
Awesome! Thanks for your work.
Won't have a lot of time to play with it until next weekend..... I played with it a bit on a test site this morning and had this in the post.
________________________________________________
Failed to add to the cache. You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' '', 'Hateful Gladiator's Leather Tunic', , NUL' at line 15
INSERT into `wowhead_cache` ( `id`, `itemid`, `name`, `search_name`, `quality`, `rank`, `type`, `lang`, `icon`, `icon_size` ) VALUES ( NULL, , '', 'Hateful Gladiator's Leather Tunic', , NULL, 'wowitem', 'en', 'NULL', 'NULL' )
_________________________________________________
Just thought I would drop the info here for now. I may have just done something wrong. I will be tinkering with it again at the end of the week and see what I can figure out.
What exactly were you doing when you got that error? The reason I ask is that the SQL query is not what it should be when searching for an item. For example, in the 'type' field it has 'wowitem'. The script only allows for 'item', 'itemico', 'spell', 'achievement', or 'quest'. This tells me that you wrongly changed the bbcode tags to "wowitem", which will break the script. Another reason I ask is that 'search_name' field if blank, which it will
NEVER
be.
If you modify the script in any way I will not support it, you're on your own. You are free to modify it as you see fit, but this is just a warning.
I am installing Joomla as we speak...currently uploading the 4k+ files.
Post by
315880
This post was from a user who has deleted their account.
Post by
7258
This post was from a user who has deleted their account.
Post by
Caldar
That would be ideal, yes, but the only problem is that unless they supply an ID for the tag rather than the name, the script doesn't know the ID. The main problem is that the script doesn't currently support IDs for craftables and itemsets. Haven't gotten around to it yet. I script only knows the ID when it: A) gets it from Wowhead B) gets it from MySQL.
In my testing when using Scourgeborne Battlegear it displays the Heroes' set, which makes sense due to it being the first set listed on the search page when going
here
. However, when you do provide the Heroes' or Valorous prefixes it correctly gets and displays them, as well as saving them to the cache for later use.
Perhaps you could clarify what is going on, or even better show an example. That way I can better understand and fix it. Also changing define('WOWHEAD_DEBUG', false); to define('WOWHEAD_DEBUG', true); in config.php could point to the problem. This will turn on debugging mode which will messily display what it finds as it works it way through the code.
By the way, in a few minutes a pretty big update is coming (for the SMF users anyways =D).
What happens is if someone enters Scourgeborne Battleplate it displays the Hero set in the post and in your wowhead_itemset database table is placed the entry:
792 Scourgeborne Battleplate Scourgeborne Battleplate en
So far so good. It also makes several entries into the wowhead_itemset_reagent for each item in the set. Again, this is fine.
Now, if someone happens to make a post that has Heroes' Scourgeborne Battleplate it makes a new entry in wowhead_itemset:
792 Heroes' Scourgeborne Battleplate Heroes' Scourgeborne Battleplate en
This is fine, but now the problem occurs.The script makes new entries in wowhead_itemset_reagent for this "new" set but since it really is not "new" it has the same itemset number of 792 thereby duplicating what was already in that table and in effect creating two entries for every set item. If you now refresh the page both itemset links will have 2 listings for every item in the set because the wowhead_itemset_reagent table has two entries for each item.
In short, because the script sees Scourgeborne Battleplate and Heroes' Scourgeborne Battleplate as two different items it saves them both to the database as seperate items. But because they are the same sets with the same set ID you end up getting duplicate entries in wowhead_itemset_reagent which makes the forum post display all the matching items in that table, of which there are now two per item.
Post Reply
This topic is locked. You cannot post a reply.